Bug 30289 - Enable SHARED_WORKERS for Chromium
: Enable SHARED_WORKERS for Chromium
Status: RESOLVED FIXED
: WebKit
WebCore JavaScript
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-10-11 17:10 PST by
Modified: 2009-10-13 16:40 PST (History)


Attachments
proposed patch (12.31 KB, patch)
2009-10-12 10:19 PST, Andrew Wilson
levin: review+
atwilson: commit‑queue-
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-10-11 17:10:02 PST
Need to turn on SHARED_WORKERS for Chromium, with the JS binding properly disabled.
------- Comment #1 From 2009-10-12 10:19:38 PST -------
Created an attachment (id=41049) [details]
proposed patch
------- Comment #2 From 2009-10-12 11:08:46 PST -------
(From update of attachment 41049 [details])

> diff --git a/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp b/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp
>  #include "V8Index.h"
>  #include "V8Proxy.h"
>  #include "V8WorkerContextEventListener.h"
> +#include "SharedWorker.h"
> +#include "SharedWorkerContext.h"

Nit: sort (Shared* before V8*)
------- Comment #3 From 2009-10-13 16:40:48 PST -------
Landed as r49526.