Bug 30289 - Enable SHARED_WORKERS for Chromium
Summary: Enable SHARED_WORKERS for Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Andrew Wilson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-11 17:10 PDT by Andrew Wilson
Modified: 2009-10-13 16:40 PDT (History)
0 users

See Also:

Attachments
proposed patch (12.31 KB, patch)
2009-10-12 10:19 PDT, Andrew Wilson 		levin: review+
atwilson: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wilson 2009-10-11 17:10:02 PDT 
Need to turn on SHARED_WORKERS for Chromium, with the JS binding properly disabled.
Comment 1 Andrew Wilson 2009-10-12 10:19:38 PDT 
Created attachment 41049 [details]
proposed patch
Comment 2 David Levin 2009-10-12 11:08:46 PDT 
Comment on attachment 41049 [details]
proposed patch


> diff --git a/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp b/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp
>  #include "V8Index.h"
>  #include "V8Proxy.h"
>  #include "V8WorkerContextEventListener.h"
> +#include "SharedWorker.h"
> +#include "SharedWorkerContext.h"

Nit: sort (Shared* before V8*)
Comment 3 Andrew Wilson 2009-10-13 16:40:48 PDT 
Landed as r49526.