WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
302855
[GLIB] Move the run loop observer repeating logic to ActivityObserver
https://bugs.webkit.org/show_bug.cgi?id=302855
Summary
[GLIB] Move the run loop observer repeating logic to ActivityObserver
Carlos Garcia Campos
Reported
2025-11-20 02:41:40 PST
This way neither the caller to notify() nor the callback need to check whether the observer is repeating or not. It's simpler, but also safer because ActivityObserver is refcounted and always protected while notify() is called, so we can safely check if it's repeating after the callback is called even if it's stopped by the callback.
Attachments
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2025-11-20 02:43:22 PST
Pull request:
https://github.com/WebKit/WebKit/pull/54242
EWS
Comment 2
2025-11-21 00:31:50 PST
Committed
303382@main
(8aa34ebe7063): <
https://commits.webkit.org/303382@main
> Reviewed commits have been landed. Closing PR #54242 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2025-11-21 00:32:12 PST
<
rdar://problem/165193416
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug