as in title
Created attachment 40990 [details] Patch v1
Comment on attachment 40990 [details] Patch v1 A few notes, even though I can’t review this patch: > + mechanical work needed to set up a webgl context for testing. It’s spelled WebGL. > + * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY This is not the correct license. > +#include "PlatformString.h" > + > +#include <wtf/PassRefPtr.h> Extra newline. > + int size() const { return m_size; } > +private: But there should be a newline before “private:” > + * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY License. > +module html { > + interface [ Should have a newline there. > + Conditional=3D_CANVAS, > + ] CanvasActiveInfo { > + readonly attribute int size; > + readonly attribute unsigned int type; > + readonly attribute DOMString name; > + }; > +} And another one before the last brace. > +PassRefPtr<CanvasActiveInfo> CanvasRenderingContext3D::getActiveAttrib(CanvasProgram* program, unsigned long index, ExceptionCode& ec) > +{ > + ec = 0; You shouldn’t reset ec. The caller should do it if it cares (the autogenerated bindings do). > +PassRefPtr<CanvasActiveInfo> CanvasRenderingContext3D::getActiveUniform(CanvasProgram* program, unsigned long index, ExceptionCode& ec) > +{ > + ec = 0; Ditto. > + bool getActiveAttrib(CanvasProgram* program, unsigned long index, ActiveInfo&); > + bool getActiveUniform(CanvasProgram* program, unsigned long index, ActiveInfo&); No need to name the “program” parameter. > #include "CachedImage.h" > +#include "CanvasActiveInfo.h" > #include "CanvasBuffer.h" > #include "CanvasFramebuffer.h" > #include "CanvasArray.h" These are not in the right order.
Created attachment 40994 [details] Patch v1
Comment on attachment 40994 [details] Patch v1 r=me
Committed r49420