Bug 30264 - [v8] Need change to V8WorkerContextEventListener::reportError signature to match the base class.
Summary: [v8] Need change to V8WorkerContextEventListener::reportError signature to ma...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-09 15:18 PDT by David Levin
Modified: 2009-10-09 17:28 PDT (History)
0 users

See Also:

Attachments
Unreviewed build fix for Windows (Cairo). (1.66 KB, patch)
2009-10-09 15:24 PDT, David Levin 		no flags Details | Formatted Diff | Diff
Fix bug. (2.13 KB, patch)
2009-10-09 15:28 PDT, David Levin 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2009-10-09 15:18:33 PDT 
This is due to http://trac.webkit.org/changeset/48884 which changed the parameters for a base class.

There was a partial fix in http://trac.webkit.org/changeset/48904 but it missed a method.

This currently causes worker-script-error.html to fail for users of v8.
Comment 1 David Levin 2009-10-09 15:24:33 PDT 
Created attachment 40967 [details]
Unreviewed build fix for Windows (Cairo).
Comment 2 David Levin 2009-10-09 15:28:01 PDT 
Comment on attachment 40967 [details]
Unreviewed build fix for Windows (Cairo).

Whoops... new tool problem.
Comment 3 David Levin 2009-10-09 15:28:31 PDT 
Created attachment 40968 [details]
Fix bug.
Comment 4 Eric Seidel (no email) 2009-10-09 16:10:55 PDT 
Comment on attachment 40968 [details]
Fix bug.

I guess v8 doesn't want to use the new param? :) rs=me.
Comment 5 David Levin 2009-10-09 17:28:10 PDT 
Committed as http://trac.webkit.org/changeset/49408