Bug 30260 - REGRESSION: Logging out from SAP doesn't work
Summary: REGRESSION: Logging out from SAP doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-10-09 13:34 PDT by Alexey Proskuryakov
Modified: 2009-10-09 17:47 PDT (History)
1 user (show)

See Also:


Attachments
proposed fix (28.21 KB, patch)
2009-10-09 13:35 PDT, Alexey Proskuryakov
beidson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2009-10-09 13:34:51 PDT
SAP uses the following code for logging out:

	var agt=navigator.userAgent.toLowerCase();
	if (agt.indexOf("msie") != -1)
	{
		document.execCommand( "ClearAuthenticationCache" );
	}
	else
	{
		var xmlhttp = createXMLObject();
		xmlhttp.open("GET", "Logoff.htm", true, "logout", "logout");
		xmlhttp.send("");
		xmlhttp.abort();
	}

This works quite differently in IE and in Firefox, but lets one log out securely. We should make the Firefox version work in WebKit (again?).

See <https://bugzilla.mozilla.org/show_bug.cgi?id=287957> for some related discussion.

<rdar://problem/6447115>
Comment 1 Alexey Proskuryakov 2009-10-09 13:35:55 PDT
Created attachment 40964 [details]
proposed fix
Comment 2 Brady Eidson 2009-10-09 15:02:06 PDT
Comment on attachment 40964 [details]
proposed fix

Fun time.  r=me
Comment 3 Brady Eidson 2009-10-09 15:02:14 PDT
Fun times*, even
Comment 4 Alexey Proskuryakov 2009-10-09 15:30:51 PDT
Committed <http://trac.webkit.org/changeset/49406>.
Comment 5 Alexey Proskuryakov 2009-10-09 17:47:29 PDT
Follow-up <http://trac.webkit.org/changeset/49410>.