WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
302506
Factor out two UnwindFunctor helper methods into an abstract base class
https://bugs.webkit.org/show_bug.cgi?id=302506
Summary
Factor out two UnwindFunctor helper methods into an abstract base class
Vassili Bykov
Reported
2025-11-13 20:39:34 PST
UnwindFunctor defined in Interpreter.cpp implements a couple of helper methods that are also useful while walking the stack during JSPI suspensions. However, there is no way to reuse those methods in JSPI because UnwindFunctor is only available in that compilation unit, and it's a concrete class implementing unwinding specifically to handle a thrown exception. To avoid code duplication, it makes sense to move the helper methods into an abstract base class inherited by UnwindFunctor, that can also be inherited by the stack visitor functor in JSPI.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2025-11-13 20:39:40 PST
<
rdar://problem/164690751
>
Vassili Bykov
Comment 2
2025-11-13 21:03:21 PST
Pull request:
https://github.com/WebKit/WebKit/pull/53914
EWS
Comment 3
2025-11-17 09:53:54 PST
Committed
303119@main
(d079117b77a9): <
https://commits.webkit.org/303119@main
> Reviewed commits have been landed. Closing PR #53914 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug