Bug 30244 – Wrong Position of #endif in Document::finishedParsing()

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Lyon Chen]

In WebCore\dom\Document.cpp, the position of #endif is wrong.

    if (Frame* f = frame()) {
        f->loader()->finishedParsing();

#if ENABLE(INSPECTOR)
        if (!page())
            return;

        if (InspectorController* controller = page()->inspectorController())
            controller->mainResourceFiredDOMContentEvent(f->loader()->documentLoader(), url());
    }
#endif

Should be changed to:

    if (Frame* f = frame()) {
        f->loader()->finishedParsing();

#if ENABLE(INSPECTOR)
        if (!page())
            return;

        if (InspectorController* controller = page()->inspectorController())
            controller->mainResourceFiredDOMContentEvent(f->loader()->documentLoader(), url());
#endif
    }

[Lyon Chen]

Created attachment 40928 [details]
Patch for bug 30244

This patch fix the error.

[Lyon Chen]

Created attachment 40946 [details]
Patch for bug 30244 with change log.

[Alexey Proskuryakov]

Comment on attachment 40946 [details]
Patch for bug 30244 with change log.

To make sure that your patch isn't overlooked, please set review flag to "?" next time.

r=me

[WebKit Commit Bot]

Comment on attachment 40946 [details]
Patch for bug 30244 with change log.

Clearing flags on attachment: 40946

Committed r49428: <http://trac.webkit.org/changeset/49428>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.