Bug 302416 – Inspector agents should use CheckedRef for InspectorEnvironment references

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Basuke Suzuki]

Inspector agents hold references to their InspectorEnvironment through the AgentContext structure. Currently, this uses a raw reference which doesn't provide any lifetime safety guarantees. If an agent outlives its environment (which should never happen but could be a bug), we'd have undefined behavior.

This change makes InspectorEnvironment inherit from CanMakeCheckedPtr and updates AgentContext to hold a CheckedRef<InspectorEnvironment>. This provides runtime checking that the environment is never destroyed while agents still reference it, making bugs more actionable by causing immediate crashes rather than subtle memory corruption.

The change required:
1. Making InspectorEnvironment support CheckedPtr/CheckedRef
2. JSGlobalObjectInspectorController implementing the AbstractCanMakeCheckedPtr interface
3. Updating AgentContext to use CheckedRef instead of a raw reference
4. Including InspectorEnvironment.h instead of forward declaring it (required for CheckedRef)

[Basuke Suzuki]

rdar://164582768

[Basuke Suzuki]

Pull request: https://github.com/WebKit/WebKit/pull/53828

[EWS]

Committed 303022@main (3db54ba8bc59): <https://commits.webkit.org/303022@main>

Reviewed commits have been landed. Closing PR #53828 and removing active labels.

[Marta Darbinyan]

Reopened Bugzilla.
REGRESSION(303022@main): [macOS Release wk1] webaudio/audiobuffersource-not-gced-until-ended.html is a flaky crash, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=302559.

[Basuke Suzuki]

<rdar://problem/165006365>

[Basuke Suzuki]

Pull request: https://github.com/WebKit/WebKit/pull/54147

[EWS]

Committed 304015@main (0f0653d9eddc): <https://commits.webkit.org/304015@main>

Reviewed commits have been landed. Closing PR #54147 and removing active labels.