Bug 30235 - [Qt] beforeload event does not fire on script elements in XML
: [Qt] beforeload event does not fire on script elements in XML
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript
: 528+ (Nightly build)
: Other Mac OS X 10.5
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-08 14:28 PDT by Jakub Wieczorek
Modified: 2009-10-09 05:32 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch (1.91 KB, patch)
2009-10-08 14:31 PDT, Jakub Wieczorek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Wieczorek 2009-10-08 14:28:17 PDT
https://bugs.webkit.org/show_bug.cgi?id=30131 made the beforeload event fire on script elements but only performed the necessary change to XMLTokenizerLibxml2.cpp, omitting the Qt tokenizer.

Affected test: fast/dom/beforeload/script-before-load-xhtml.xhtml
Comment 1 Jakub Wieczorek 2009-10-08 14:31:45 PDT
Created attachment 40912 [details]
proposed patch
Comment 2 Simon Hausmann 2009-10-09 04:56:28 PDT
Comment on attachment 40912 [details]
proposed patch

Good catch, thanks!
Comment 3 WebKit Commit Bot 2009-10-09 05:32:13 PDT
Comment on attachment 40912 [details]
proposed patch

Clearing flags on attachment: 40912

Committed r49388: <http://trac.webkit.org/changeset/49388>
Comment 4 WebKit Commit Bot 2009-10-09 05:32:16 PDT
All reviewed patches have been landed.  Closing bug.