Bug 30235 - [Qt] beforeload event does not fire on script elements in XML
: [Qt] beforeload event does not fire on script elements in XML
Status: RESOLVED FIXED
: WebKit
WebCore JavaScript
: 528+ (Nightly build)
: Other Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-10-08 14:28 PST by
Modified: 2009-10-09 05:32 PST (History)


Attachments
proposed patch (1.91 KB, patch)
2009-10-08 14:31 PST, Jakub Wieczorek
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-10-08 14:28:17 PST
https://bugs.webkit.org/show_bug.cgi?id=30131 made the beforeload event fire on script elements but only performed the necessary change to XMLTokenizerLibxml2.cpp, omitting the Qt tokenizer.

Affected test: fast/dom/beforeload/script-before-load-xhtml.xhtml
------- Comment #1 From 2009-10-08 14:31:45 PST -------
Created an attachment (id=40912) [details]
proposed patch
------- Comment #2 From 2009-10-09 04:56:28 PST -------
(From update of attachment 40912 [details])
Good catch, thanks!
------- Comment #3 From 2009-10-09 05:32:13 PST -------
(From update of attachment 40912 [details])
Clearing flags on attachment: 40912

Committed r49388: <http://trac.webkit.org/changeset/49388>
------- Comment #4 From 2009-10-09 05:32:16 PST -------
All reviewed patches have been landed.  Closing bug.