Bug 30231 - isolated world tests were broken by recent signature change to LayoutTestController
Summary: isolated world tests were broken by recent signature change to LayoutTestCont...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Aaron Boodman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-08 12:14 PDT by Aaron Boodman
Modified: 2009-10-08 14:28 PDT (History)
3 users (show)

See Also:


Attachments
Fix bug. (14.46 KB, patch)
2009-10-08 12:19 PDT, Aaron Boodman
no flags Details | Formatted Diff | Diff
Patch with better ChangeLog description (14.82 KB, patch)
2009-10-08 12:28 PDT, Aaron Boodman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Boodman 2009-10-08 12:14:57 PDT
LayoutTestController::evaluateInIsolatedWorld now requires two arguments.
Comment 1 Aaron Boodman 2009-10-08 12:19:47 PDT
Created attachment 40898 [details]
Fix bug.
Comment 2 Aaron Boodman 2009-10-08 12:28:45 PDT
Created attachment 40899 [details]
Patch with better ChangeLog description
Comment 3 Eric Seidel (no email) 2009-10-08 12:33:15 PDT
Comment on attachment 40899 [details]
Patch with better ChangeLog description

Looks fine.  I think an optional last argument would have been slicker, but this is fine. :)
Comment 4 WebKit Commit Bot 2009-10-08 14:28:08 PDT
Comment on attachment 40899 [details]
Patch with better ChangeLog description

Clearing flags on attachment: 40899

Committed r49321: <http://trac.webkit.org/changeset/49321>
Comment 5 WebKit Commit Bot 2009-10-08 14:28:12 PDT
All reviewed patches have been landed.  Closing bug.