RESOLVED INVALID 30229
[GTK] Exception control in EventSender is not correct 
https://bugs.webkit.org/show_bug.cgi?id=30229
Summary [GTK] Exception control in EventSender is not correct
Alejandro G. Castro
Reported 2009-10-08 12:00:39 PDT
In EventSender.cpp we are controlling the exceptions with lines like this one: g_return_val_if_fail((!exception || !*exception), JSValueMakeUndefined(context)); We should use && instead of ||, and we could even leave (!*exception) if we can assure the parameter is always initialized.
Attachments
Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-10-12 16:45:42 PDT
I think || is correct here. I'm cleaning up bugs, so I'll close this, but feel free to reopen it if I'm wrong.
Note You need to log in before you can comment on or make changes to this bug.