Bug 30229 - [GTK] Exception control in EventSender is not correct
Summary: [GTK] Exception control in EventSender is not correct
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-08 12:00 PDT by Alejandro G. Castro
Modified: 2010-10-12 16:45 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2009-10-08 12:00:39 PDT 
In EventSender.cpp we are controlling the exceptions with lines like this one:

    g_return_val_if_fail((!exception || !*exception), JSValueMakeUndefined(context));

We should use && instead of ||, and we could even leave (!*exception) if we can assure the parameter is always initialized.
Comment 1 Martin Robinson 2010-10-12 16:45:42 PDT 
I think || is correct here. I'm cleaning up bugs, so I'll close this, but feel free to reopen it if I'm wrong.