Bug 302255 – [LibWebRTC][Linux] VP9 encoding broken

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Philippe Normand]

In a f43 container, the vpx init reports an ABI version mismatch.

[Philippe Normand]

VPX_EXT_RATECTRL_ABI_VERSION in my fedora libvpx is currently "(5 + VPX_TPL_ABI_VERSION)" while in the bundled libwebrtc headers, its is "(6 + VPX_TPL_ABI_VERSION)"

I'm not sure how this is supposed to reliably work without using the bundled vpx lib. Any thoughts, Carlos?

[Philippe Normand]

The workaround would be to make sure we include the system vpx headers from libwebrtc, instead of the bundled headers, but that's not upstreamable in libwebrtc and thus is unlikely to survive libwebrtc bundle upgrades.

[Philippe Normand]

Pull request: https://github.com/WebKit/WebKit/pull/53869

[Radar WebKit Bug Importer]

<rdar://problem/164881562>

[Adrian Perez]

(In reply to Philippe Normand from comment #2)
> The workaround would be to make sure we include the system vpx headers from
> libwebrtc, instead of the bundled headers, but that's not upstreamable in
> libwebrtc and thus is unlikely to survive libwebrtc bundle upgrades.

I think it's worthwhile to make sure we can build against a system-installed
libvpx *if* we want to make it possible for distributions to enable WebRTC
support using libwebrtc. After giving it some thought, and given that this is
not something supported right now, IMO it is fine to use the bundled copy
for the time being. We might want to revisit this at a later time, although it
may as well be that distributions may prefer to use gst-webrtc instead.

[EWS]

Committed 303128@main (49b71e2d05c0): <https://commits.webkit.org/303128@main>

Reviewed commits have been landed. Closing PR #53869 and removing active labels.

[Diego Pino]

Re-opening for pull request https://github.com/WebKit/WebKit/pull/54554

[EWS]

Committed 303628@main (7772230df6f4): <https://commits.webkit.org/303628@main>

Reviewed commits have been landed. Closing PR #54554 and removing active labels.