Bug 30217 - SVGURIReference Build problem for V8
Summary: SVGURIReference Build problem for V8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: John Gregg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-08 09:43 PDT by John Gregg
Modified: 2009-10-08 14:20 PDT (History)
1 user (show)

See Also:


Attachments
patch (1.58 KB, patch)
2009-10-08 09:55 PDT, John Gregg
eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
better patch (1.59 KB, patch)
2009-10-08 09:58 PDT, John Gregg
no flags Details | Formatted Diff | Diff
patch part 2 (1.02 KB, patch)
2009-10-08 13:25 PDT, John Gregg
dglazkov: review+
atwilson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Gregg 2009-10-08 09:43:50 PDT
We don't need to directly build SVGURIReference in V8 - these properties are only accessed by inheritance; it used to be harmless but recent changes cause it to fail in compile.
Comment 1 John Gregg 2009-10-08 09:55:31 PDT
Created attachment 40881 [details]
patch
Comment 2 John Gregg 2009-10-08 09:56:53 PDT
To be more specific, the fix is to not generate and compile in code directly from SVGURIReference.idl.  The interface therein should only be used through derived classes.
Comment 3 Eric Seidel (no email) 2009-10-08 09:56:55 PDT
Comment on attachment 40881 [details]
patch

Tab in ChangeLog will cause commit to fail.  Normally I don't put anything around urls, the [] seem superfluous to me.

LGTM.
Comment 4 John Gregg 2009-10-08 09:58:10 PDT
Created attachment 40882 [details]
better patch
Comment 5 John Gregg 2009-10-08 13:25:54 PDT
Created attachment 40906 [details]
patch part 2

A second patch is required to fix this problem, as the .h file is still referenced.
Comment 6 Dimitri Glazkov (Google) 2009-10-08 13:30:39 PDT
Comment on attachment 40906 [details]
patch part 2

r=me.
Comment 7 John Gregg 2009-10-08 14:17:13 PDT
Comment on attachment 40882 [details]
better patch

already applied.
Comment 8 Andrew Wilson 2009-10-08 14:20:05 PDT
Landed as r49319