RESOLVED FIXED 30189
Back out StringImpl::m_buffer to make MSVC happy 
https://bugs.webkit.org/show_bug.cgi?id=30189
Summary Back out StringImpl::m_buffer to make MSVC happy
Jens Alfke
Reported 2009-10-07 17:11:44 PDT
Created attachment 40830 [details] patch It's not worth having the variable-length-array m_buffer in StringImpl if MSVC doesn't handle it well. So this patch removes it and goes back to the hack of offsetting the base pointer by sizeof(StringImpl).
Attachments
patch (3.29 KB, patch)
2009-10-07 17:11 PDT, Jens Alfke 		no flags
DetailsFormatted DiffDiff
removed unwanted space char (3.29 KB, patch)
2009-10-07 17:16 PDT, Jens Alfke 		no flags
DetailsFormatted DiffDiff
now with changelog entry, duh (4.04 KB, patch)
2009-10-07 17:20 PDT, Jens Alfke 		levin: review+
levin: commit-queue-
DetailsFormatted DiffDiff
remove commented declaration (4.00 KB, patch)
2009-10-07 17:21 PDT, Jens Alfke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jens Alfke
Comment 1 2009-10-07 17:16:46 PDT
Created attachment 40831 [details] removed unwanted space char
Jens Alfke
Comment 2 2009-10-07 17:20:12 PDT
Created attachment 40832 [details] now with changelog entry, duh
David Levin
Comment 3 2009-10-07 17:21:03 PDT
Comment on attachment 40832 [details] now with changelog entry, duh > + // const UChar m_fictitious_buffer[]; Whoever lands this, please delete this line.
Jens Alfke
Comment 4 2009-10-07 17:21:22 PDT
Created attachment 40833 [details] remove commented declaration
Jeremy Orlow
Comment 5 2009-10-07 17:41:38 PDT
Committed r49279: <http://trac.webkit.org/changeset/49279>
Eric Seidel (no email)
Comment 6 2009-10-07 21:49:47 PDT
Comment on attachment 40833 [details] remove commented declaration This was landed. Thank you Jens for the quick fix, and thank you Jeremy for the commit.
Note You need to log in before you can comment on or make changes to this bug.