Bug 30189 - Back out StringImpl::m_buffer to make MSVC happy
Summary: Back out StringImpl::m_buffer to make MSVC happy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P2 Major
Assignee: Jens Alfke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-07 17:11 PDT by Jens Alfke
Modified: 2009-10-07 21:49 PDT (History)
1 user (show)

See Also:

Attachments
patch (3.29 KB, patch)
2009-10-07 17:11 PDT, Jens Alfke 		no flags Details | Formatted Diff | Diff
removed unwanted space char (3.29 KB, patch)
2009-10-07 17:16 PDT, Jens Alfke 		no flags Details | Formatted Diff | Diff
now with changelog entry, duh (4.04 KB, patch)
2009-10-07 17:20 PDT, Jens Alfke 		levin: review+
levin: commit-queue-
Details | Formatted Diff | Diff
remove commented declaration (4.00 KB, patch)
2009-10-07 17:21 PDT, Jens Alfke 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Alfke 2009-10-07 17:11:44 PDT 
Created attachment 40830 [details]
patch

It's not worth having the variable-length-array m_buffer in StringImpl if MSVC doesn't handle it well. So this patch removes it and goes back to the hack of offsetting the base pointer by sizeof(StringImpl).
Comment 1 Jens Alfke 2009-10-07 17:16:46 PDT 
Created attachment 40831 [details]
removed unwanted space char
Comment 2 Jens Alfke 2009-10-07 17:20:12 PDT 
Created attachment 40832 [details]
now with changelog entry, duh
Comment 3 David Levin 2009-10-07 17:21:03 PDT 
Comment on attachment 40832 [details]
now with changelog entry, duh


> +    // const UChar m_fictitious_buffer[];
Whoever lands this, please delete this line.
Comment 4 Jens Alfke 2009-10-07 17:21:22 PDT 
Created attachment 40833 [details]
remove commented declaration
Comment 5 Jeremy Orlow 2009-10-07 17:41:38 PDT 
Committed r49279: <http://trac.webkit.org/changeset/49279>
Comment 6 Eric Seidel (no email) 2009-10-07 21:49:47 PDT 
Comment on attachment 40833 [details]
remove commented declaration

This was landed.  Thank you Jens for the quick fix, and thank you Jeremy for the commit.