WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
30185
Expose origin whitelisting in the WebKit API on Windows
https://bugs.webkit.org/show_bug.cgi?id=30185
Summary
Expose origin whitelisting in the WebKit API on Windows
Adam Roben (:aroben)
Reported
2009-10-07 14:11:10 PDT
Created
attachment 40821
[details]
Patch v1 Catching up to Mac.
Attachments
Patch v1
(7.44 KB, patch)
2009-10-07 14:11 PDT
,
Adam Roben (:aroben)
eric
: review+
eric
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2009-10-07 21:58:39 PDT
Comment on
attachment 40821
[details]
Patch v1 rs=me. If you need an in-depth windows review then you should get a windows person to look at this too, but it looks right as far as I can tell! looks like you didn't use prepare-ChangeLog --
bug 12345
Or maybe you used bugzilla-tool create-bug and that doesn't know how to fix ChangeLogs yet? Donno. Obviously the ChangeLogs will need to be fixed, but I assume you plan to commit this yourself anyway.
Adam Roben (:aroben)
Comment 2
2009-10-08 06:50:29 PDT
(In reply to
comment #1
)
> (From update of
attachment 40821
[details]
) > looks like you didn't use prepare-ChangeLog --
bug 12345
> Or maybe you used bugzilla-tool create-bug and that doesn't know how to fix > ChangeLogs yet? Donno.
The latter.
> Obviously the ChangeLogs will need to be fixed, but I assume you plan to commit > this yourself anyway.
Yes. Should I set cq- on patches that I upload when I plan to land them myself? Thanks for reviewing!
Adam Roben (:aroben)
Comment 3
2009-10-08 07:11:01 PDT
Committed
r49299
: <
http://trac.webkit.org/changeset/49299
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug