WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
301842
TrackPrivateBase's label/language should return a String
https://bugs.webkit.org/show_bug.cgi?id=301842
Summary
TrackPrivateBase's label/language should return a String
Jean-Yves Avenard [:jya]
Reported
2025-11-02 21:36:21 PST
TrackPrivateBase::label() and TrackPrivateBase::language() are returning an AtomString even though TrackPrivateBase is a ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr which is incompatible with AtomStrings (they must be deleted on the same thread they were creating). We should make them return a String instead as the SourceBuffer/SourceBufferPrivate where TrackPrivateBase objects are created may no longer be on the main thread once we move to having the MediaPlayer back in the web process.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2025-11-02 21:36:27 PST
<
rdar://problem/163911707
>
Jean-Yves Avenard [:jya]
Comment 2
2025-11-02 22:00:29 PST
Pull request:
https://github.com/WebKit/WebKit/pull/53327
EWS
Comment 3
2025-11-04 02:47:57 PST
Committed
302527@main
(bd2c5cb034ca): <
https://commits.webkit.org/302527@main
> Reviewed commits have been landed. Closing PR #53327 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug