Bug 30184 - Move SVGURIReference ANIMATED_* macros in classes that inherit from it
Summary: Move SVGURIReference ANIMATED_* macros in classes that inherit from it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 30183
  Show dependency treegraph
 
Reported: 2009-10-07 14:10 PDT by Nikolas Zimmermann
Modified: 2009-10-11 00:42 PDT (History)
1 user (show)

See Also:


Attachments
Initial patch (21.54 KB, patch)
2009-10-07 14:16 PDT, Nikolas Zimmermann
staikos: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2009-10-07 14:10:16 PDT
Read bug 30183. This bug tracks the removal of the macros from SVGURIReference.
Comment 1 Nikolas Zimmermann 2009-10-07 14:16:03 PDT
Created attachment 40823 [details]
Initial patch
Comment 2 WebKit Commit Bot 2009-10-07 15:41:45 PDT
Comment on attachment 40823 [details]
Initial patch

Rejecting patch 40823 from commit-queue.

Patch https://bugs.webkit.org/attachment.cgi?id=40823 from bug 30184 failed to download and apply.
Comment 3 Nikolas Zimmermann 2009-10-08 07:59:31 PDT
Landed in r49301.
Comment 4 Eric Seidel (no email) 2009-10-08 09:42:48 PDT
Comment on attachment 40823 [details]
Initial patch

LGTM.

We can kill these lines when we see them:
55     This file is part of the KDE project

they're no longer correct.
Comment 5 Nikolas Zimmermann 2009-10-08 09:54:31 PDT
Okay, I will take care of that in the next patch, that's about to be submitted.
Comment 6 Eric Seidel (no email) 2009-10-09 14:32:43 PDT
Looks like this was rejected becasue the paths in the patch were not from the root directory.
Comment 7 Nikolas Zimmermann 2009-10-11 00:42:30 PDT
Sorry about that -- I fixed my python installation and can use bugzilla-tool again.