WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
30184
Move SVGURIReference ANIMATED_* macros in classes that inherit from it
https://bugs.webkit.org/show_bug.cgi?id=30184
Summary
Move SVGURIReference ANIMATED_* macros in classes that inherit from it
Nikolas Zimmermann
Reported
2009-10-07 14:10:16 PDT
Read
bug 30183
. This bug tracks the removal of the macros from SVGURIReference.
Attachments
Initial patch
(21.54 KB, patch)
2009-10-07 14:16 PDT
,
Nikolas Zimmermann
staikos
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1
2009-10-07 14:16:03 PDT
Created
attachment 40823
[details]
Initial patch
WebKit Commit Bot
Comment 2
2009-10-07 15:41:45 PDT
Comment on
attachment 40823
[details]
Initial patch Rejecting patch 40823 from commit-queue. Patch
https://bugs.webkit.org/attachment.cgi?id=40823
from
bug 30184
failed to download and apply.
Nikolas Zimmermann
Comment 3
2009-10-08 07:59:31 PDT
Landed in
r49301
.
Eric Seidel (no email)
Comment 4
2009-10-08 09:42:48 PDT
Comment on
attachment 40823
[details]
Initial patch LGTM. We can kill these lines when we see them: 55 This file is part of the KDE project they're no longer correct.
Nikolas Zimmermann
Comment 5
2009-10-08 09:54:31 PDT
Okay, I will take care of that in the next patch, that's about to be submitted.
Eric Seidel (no email)
Comment 6
2009-10-09 14:32:43 PDT
Looks like this was rejected becasue the paths in the patch were not from the root directory.
Nikolas Zimmermann
Comment 7
2009-10-11 00:42:30 PDT
Sorry about that -- I fixed my python installation and can use bugzilla-tool again.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug