Bug 30182 - Animation stalls for a few seconds partway through
Summary: Animation stalls for a few seconds partway through
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-07 13:54 PDT by Simon Fraser (smfr)
Modified: 2010-04-30 16:03 PDT (History)
0 users

See Also:

Attachments
Patch (1.61 KB, patch)
2009-10-07 14:03 PDT, Simon Fraser (smfr) 		mitz: review+
Details | Formatted Diff | Diff
I think this testcase reproduces the problem (1.42 KB, text/html)
2010-04-30 16:03 PDT, Simon Fraser (smfr) 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-10-07 13:54:33 PDT 
If you run the attached testcase with layer borders turned on, you'll see that the animating red box stalls for a couple of seconds part-way through.

The issue is that we're calling -disableScreenUpdatesUntilFlush on the NSWindow when there is actually no view drawing to be done, so that the window flush never happens. This means that screen updates end up being disabled until the watchdog enables them again (after 2 seconds).
Comment 1 Simon Fraser (smfr) 2009-10-07 14:03:37 PDT 
Created attachment 40820 [details]
Patch
Comment 2 Simon Fraser (smfr) 2009-10-07 15:53:31 PDT 
http://trac.webkit.org/changeset/49269
Comment 3 Simon Fraser (smfr) 2010-04-30 16:03:42 PDT 
Created attachment 54830 [details]
I think this testcase reproduces the problem