Bug 30174 - Web Inspector: Wrap Database into ScriptObject in v8 bindings.
Summary: Web Inspector: Wrap Database into ScriptObject in v8 bindings.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2009-10-07 09:52 PDT by Pavel Feldman
Modified: 2009-10-09 09:36 PDT (History)
1 user (show)

See Also:

patch (1.76 KB, patch)
2009-10-07 09:58 PDT, Pavel Feldman
abarth: review-
Details | Formatted Diff | Diff
patch with comments addressed (2.26 KB, patch)
2009-10-07 11:50 PDT, Pavel Feldman
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-10-07 09:52:51 PDT
There is a TODO that should be replaced with the real implementation for database tab to work in Chromium.
Comment 1 Pavel Feldman 2009-10-07 09:58:42 PDT
Created attachment 40801 [details]
Comment 2 Adam Barth 2009-10-07 11:39:46 PDT
Comment on attachment 40801 [details]


+	Frame* frame = database->document()->frame();

This line has a tab.

What if frame() is null?

+    // FIXME: What if context.IsEmpty()?

You need to handle this case!

+    ScriptState* scriptState = frame->page()->inspectorController()->frontendScriptState();

What if page() is null?
Comment 3 Pavel Feldman 2009-10-07 11:50:11 PDT
Created attachment 40809 [details]
patch with comments addressed
Comment 4 Dimitri Glazkov (Google) 2009-10-09 08:49:45 PDT
Comment on attachment 40809 [details]
patch with comments addressed


Pls add a line to ChangeLog entry explaining that there's no way to test this atm.
Comment 5 Pavel Feldman 2009-10-09 09:36:33 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/ScriptObjectQuarantine.cpp
Committed r49393