RESOLVED FIXED30174
Web Inspector: Wrap Database into ScriptObject in v8 bindings. 
https://bugs.webkit.org/show_bug.cgi?id=30174
Summary Web Inspector: Wrap Database into ScriptObject in v8 bindings.
Pavel Feldman
Reported 2009-10-07 09:52:51 PDT
There is a TODO that should be replaced with the real implementation for database tab to work in Chromium.
Attachments
patch (1.76 KB, patch)
2009-10-07 09:58 PDT, Pavel Feldman 		abarth: review-
DetailsFormatted DiffDiff
patch with comments addressed (2.26 KB, patch)
2009-10-07 11:50 PDT, Pavel Feldman 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-10-07 09:58:42 PDT
Created attachment 40801 [details] patch
Adam Barth
Comment 2 2009-10-07 11:39:46 PDT
Comment on attachment 40801 [details] patch Test? + Frame* frame = database->document()->frame(); This line has a tab. What if frame() is null? + // FIXME: What if context.IsEmpty()? You need to handle this case! + ScriptState* scriptState = frame->page()->inspectorController()->frontendScriptState(); What if page() is null?
Pavel Feldman
Comment 3 2009-10-07 11:50:11 PDT
Created attachment 40809 [details] patch with comments addressed
Dimitri Glazkov (Google)
Comment 4 2009-10-09 08:49:45 PDT
Comment on attachment 40809 [details] patch with comments addressed r=me. Pls add a line to ChangeLog entry explaining that there's no way to test this atm.
Pavel Feldman
Comment 5 2009-10-09 09:36:33 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/ScriptObjectQuarantine.cpp Committed r49393
Note You need to log in before you can comment on or make changes to this bug.