Bug 30168 - REGRESSION (r49213): http/tests/plugins/local-geturl-from-remote.html is failing on Windows
Summary: REGRESSION (r49213): http/tests/plugins/local-geturl-from-remote.html is fail...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-07 08:08 PDT by Adam Roben (:aroben)
Modified: 2009-10-08 06:49 PDT (History)
3 users (show)

See Also:


Attachments
Patch v1 (1.59 KB, patch)
2009-10-07 08:08 PDT, Adam Roben (:aroben)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-10-07 08:08:06 PDT
Created attachment 40788 [details]
Patch v1

r49213 contained a typo that is causing http/tests/plugins/local-geturl-from-remote.html to fail on Windows.
Comment 1 Adam Roben (:aroben) 2009-10-07 08:12:34 PDT
Committed r49244: <http://trac.webkit.org/changeset/49244>
Comment 2 Adam Barth 2009-10-07 08:58:35 PDT
Thanks for fixing this.  How did the old code even compile?
Comment 3 Alexey Proskuryakov 2009-10-07 21:23:43 PDT
> How did the old code even compile?

It's operator comma, which is often used in for loops, but is universally available in fact:

for (i =0, j = 0; i != 1; i++, j++) {...}

The value of such an expression is the value of the last sub-expression. Unless I'm hallucinating, the ChangeLog comment here got it wrong (the condition was always false, not always true).
Comment 4 Adam Barth 2009-10-07 21:26:17 PDT
Wow, that's ridiculous.  Thanks for explaining.
Comment 5 Adam Roben (:aroben) 2009-10-08 06:49:20 PDT
(In reply to comment #3)
> Unless
> I'm hallucinating, the ChangeLog comment here got it wrong (the condition was
> always false, not always true).

The ChangeLog was wrong.