Bug 30166 - [Qt] Get rid of useless loadFailed signal in QGraphicsWebView
Summary: [Qt] Get rid of useless loadFailed signal in QGraphicsWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-10-07 07:40 PDT by Antonio Gomes
Modified: 2009-10-07 08:25 PDT (History)
2 users (show)

See Also:


Attachments
(committed r49245) patch 0.1 - remove loadFailed in favor of loadFineshed + bool success (3.36 KB, patch)
2009-10-07 07:44 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2009-10-07 07:40:48 PDT
In QWebView we have only loadFinished(bool success), but we tried to improved that for QGraphicsWebView introducing a new loadFailed signal.

This signal is now useless since error handling is being possible through somewhere else (ErrorPageExtension).

we should remove this loadFailed signal from QGraphicsWebView, making it compatible to QWebView in that sense.
Comment 1 Antonio Gomes 2009-10-07 07:44:50 PDT
Created attachment 40787 [details]
(committed r49245) patch 0.1 - remove loadFailed in favor of loadFineshed + bool success
Comment 2 Antonio Gomes 2009-10-07 08:24:54 PDT
r49245
Comment 3 Antonio Gomes 2009-10-07 08:25:50 PDT
Comment on attachment 40787 [details]
(committed r49245) patch 0.1 - remove loadFailed in favor of loadFineshed + bool success

clearing r+ flag since it landed.