Bug 30164 - Video keeps playing after going fullscreen, then closing window
Summary: Video keeps playing after going fullscreen, then closing window
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-07 07:28 PDT by Simon Fraser (smfr)
Modified: 2009-10-12 09:30 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.25 KB, patch)
2009-10-12 09:07 PDT, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-10-07 07:28:34 PDT 
Steps:
1. Play a video element
2. Go fullscreen
3. Exit fullscreen
4. Close window.

The video keeps playing (or, at least it did when I tried this on cuteoverload.com with Click To Flash installed).
Comment 1 Simon Fraser (smfr) 2009-10-07 11:30:45 PDT 
May be related to bug 30119
Comment 2 Simon Fraser (smfr) 2009-10-12 09:07:27 PDT 
Created attachment 41047 [details]
Patch
Comment 3 Darin Adler 2009-10-12 09:15:36 PDT 
Comment on attachment 41047 [details]
Patch

> +    QTMovieView *movieView = [[self fullscreenWindow] movieView];
> +    [movieView setMovie:nil];

I would have done this on a single line without a local variable.

I would have included a comment, since it's not obvious that the reason this is critical is that it stops the movie from playing. Further, the comment could clarify whether this is a workaround for a QTMovieView bug or if it's simply a subtle aspect of the design of QTMovieView, as well.
Comment 4 Simon Fraser (smfr) 2009-10-12 09:28:29 PDT 
I filed <rdar://problem/7295070> on the underlying problem.
Comment 5 Simon Fraser (smfr) 2009-10-12 09:30:13 PDT 
http://trac.webkit.org/changeset/49443