Bug 30157 – [Qt] Symbian SBSv2 .code segment is too big for linker

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Janne Koskinen]

Symbian's new build toolchain SBSv2 (Symbian Build System version 2) creates more code than the old SBSv1.
Toolchain has a fixed start address for .data segment that .code segment overlaps with in SBSv2 causing
the link stage to fail when building qtwebkit.dll.

[Janne Koskinen]

Created attachment 40771 [details]
proposed fix for webcore.pro

Patch increases the base address of .data segment by passing linkeroption to RVCT's armlink.

[Janne Koskinen]

Created attachment 40776 [details]
proposed fix for webcore.pro take 2

removed the test cases missing part from changelog.

[WebKit Commit Bot]

Comment on attachment 40776 [details]
proposed fix for webcore.pro take 2

Rejecting patch 40776 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11400 test cases.
storage/close-during-stress-test.html -> crashed

Exiting early after 1 failures. 9384 tests run.
481.84s total testing time

9383 test cases (99%) succeeded
1 test case (<1%) crashed
6 test cases (<1%) had stderr output

[Simon Hausmann]

Comment on attachment 40776 [details]
proposed fix for webcore.pro take 2

Overriding the bot here, this patch cannot possibly have affected the failing test :)

[WebKit Commit Bot]

Comment on attachment 40776 [details]
proposed fix for webcore.pro take 2

Clearing flags on attachment: 40776

Committed r49239: <http://trac.webkit.org/changeset/49239>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

(In reply to comment #4)
> (From update of attachment 40776 [details])
> Overriding the bot here, this patch cannot possibly have affected the failing
> test :)

Agreed.  Although when that happens we need to be sure to file bugs about the flakey tests. :)  (Which is my job, don't get me wrong.  But if somehow I don't notice a flakey test like this in the future, feel free/encouraged to ping me about it or CC me on the bug.)  Filed bug 30172.