30151 – Halted plug-ins should restart when hovered

Bug 30151 - Halted plug-ins should restart when hovered

Summary: Halted plug-ins should restart when hovered

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Plug-ins (show other bugs)
Version:	528+ (Nightly build)
Hardware:	PC Windows XP

Importance:	P2 Normal
Assignee:	Jon Honeycutt

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2009-10-06 22:20 PDT by Jon Honeycutt
Modified:	2009-10-19 15:55 PDT (History)
CC List:	5 users (show)

See Also:

Attachments
patch (20.26 KB, patch) 2009-10-06 23:51 PDT, Jon Honeycutt	no flags	Details \| Formatted Diff \| Diff
Expose whether an element is a halted plug-in in HitTestResult (31.51 KB, patch) 2009-10-14 00:12 PDT, Jon Honeycutt	darin: review+ jhoneycutt: commit-queue-	Details \| Formatted Diff \| Diff
Add SPI to determine whether a node is a halted plug-in (7.92 KB, patch) 2009-10-14 22:44 PDT, Jon Honeycutt	darin: review+ jhoneycutt: commit-queue-	Details \| Formatted Diff \| Diff
Add SPI to restart a halted plug-in (4.09 KB, patch) 2009-10-15 17:15 PDT, Jon Honeycutt	jhoneycutt: commit-queue-	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jon Honeycutt 2009-10-06 22:20:24 PDT

Plug-ins that have been automatically halted by the PluginHalter should restart when hovered with the mouse.

<rdar://problem/7273354>

Comment 1 Jon Honeycutt 2009-10-06 23:51:09 PDT

Created attachment 40766 [details]
patch

Comment 2 Adam Roben (:aroben) 2009-10-07 08:22:50 PDT

Comment on attachment 40766 [details]
patch

Couldn't the UI delegate implement this policy using mouseDidMoveOverElement?

Comment 3 Jon Honeycutt 2009-10-07 19:48:18 PDT

Sure - Dan suggested that we could expose that the element is a halted plug-in in mouseDidMoveOverElement(), then add SPI to WebView to restart the plug-in for a given DOM node. Does that sound like a better approach?

Comment 4 Adam Roben (:aroben) 2009-10-08 06:47:57 PDT

(In reply to comment #3)
> Sure - Dan suggested that we could expose that the element is a halted plug-in
> in mouseDidMoveOverElement(), then add SPI to WebView to restart the plug-in
> for a given DOM node. Does that sound like a better approach?

That sounds good to me. Maybe we should get Hyatt's opinion before thrashing further.

Comment 5 Jon Honeycutt 2009-10-14 00:12:59 PDT

Created attachment 41152 [details]
Expose whether an element is a halted plug-in in HitTestResult

I'm working on the test for this.

Comment 6 Simon Fraser (smfr) 2009-10-14 14:33:55 PDT

I don't like adding isOverHaltedPlugin to HitTestResult. If we did this for every other special kind of thing that the mouse can possibly be over, then HitTestResult would large and unwieldy.

Comment 7 Jon Honeycutt 2009-10-14 22:44:01 PDT

Created attachment 41208 [details]
Add SPI to determine whether a node is a halted plug-in

Rather than adding information about halted plug-ins to HitTestResult, this adds SPI to WebView to determine whether a node is a halted plug-in.

Windows side of this. Working on a test.

Comment 8 Jon Honeycutt 2009-10-15 17:13:39 PDT

Landed in http://trac.webkit.org/changeset/49666.

Comment 9 Jon Honeycutt 2009-10-15 17:15:58 PDT

Created attachment 41252 [details]
Add SPI to restart a halted plug-in

Comment 10 Jon Honeycutt 2009-10-16 17:58:24 PDT

(In reply to comment #9)
> Created an attachment (id=41252) [details]
> Add SPI to restart a halted plug-in

Kevin Decker reviewed this. It was landed in http://trac.webkit.org/changeset/49699.

Comment 11 Jon Honeycutt 2009-10-16 17:58:54 PDT

Comment on attachment 41252 [details]
Add SPI to restart a halted plug-in

Clearing review flag.

Comment 12 Eric Seidel (no email) 2009-10-19 15:20:47 PDT

Should this bug still be open?

Comment 13 Jon Honeycutt 2009-10-19 15:55:12 PDT

Nope, closing.