RESOLVED FIXED301469
webkitscmpy.program.command shouldn't hardcode "Canonical link" 
https://bugs.webkit.org/show_bug.cgi?id=301469
Summary webkitscmpy.program.command shouldn't hardcode "Canonical link"
Sam Sneddon [:gsnedders]
Reported 2025-10-25 12:39:13 PDT
As part of bug 266028, we need to migrate everything to supporting actual git trailers. We have: ``` Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py 79: NO_FILTER_RES = [re.compile(r' Canonical link:'), re.compile(r' git-svn-id:')] ``` I'm not totally sure what the goal of this is, because making the list empty still has all the tests passing, and trying to run e.g. `git-webkit log --hash` just makes the functionality seem pretty broken. Thinking about this in abstract, I don't know when it expects it to be indented v. when not, as for `git-webkit log` this depends on the `--format` (etc.) option. Either way, we should at the least look at `identifier_template` rather than hardcoding this.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2025-10-25 12:39:19 PDT
<rdar://problem/163410599>
Sam Sneddon [:gsnedders]
Comment 2 2026-06-05 18:06:11 PDT
Pull request: https://github.com/WebKit/WebKit/pull/66602
EWS
Comment 3 2026-06-05 18:18:13 PDT
Committed 314679@main (2ad20f50e243): <https://commits.webkit.org/314679@main> Reviewed commits have been landed. Closing PR #66602 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.