WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
301400
[JSC] Remove unnecessary `inline` from `WeakGCSet` constructor and destructor
https://bugs.webkit.org/show_bug.cgi?id=301400
Summary
[JSC] Remove unnecessary `inline` from `WeakGCSet` constructor and destructor
Sosuke Suzuki
Reported
2025-10-23 21:56:56 PDT
Our LTO build fails via `inline` for declartions of `WeakGCSet` constructor and destructor. These functions should still be inlined even if `inline` is removed from their declarations, because they are defined with `inline` in `WeakGCSetInlines.h` (as is already the case for `WeakGCMap`). So this patch removes `inline` from these functions.
Attachments
Add attachment
proposed patch, testcase, etc.
Sosuke Suzuki
Comment 1
2025-10-23 21:58:18 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/52930
EWS
Comment 2
2025-10-23 23:34:12 PDT
Committed
302074@main
(874cd3bb87fb): <
https://commits.webkit.org/302074@main
> Reviewed commits have been landed. Closing PR #52930 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2025-10-23 23:35:13 PDT
<
rdar://problem/163319360
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug