RESOLVED FIXED 30132
Make beforeload work with link/xml-stylesheet elements 
https://bugs.webkit.org/show_bug.cgi?id=30132
Summary Make beforeload work with link/xml-stylesheet elements
Dave Hyatt
Reported 2009-10-06 10:38:50 PDT
Make beforeload work with stylesheet loads.
Attachments
Add support for beforeload for stylesheet loads (14.51 KB, patch)
2009-10-06 12:50 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (14.43 KB, patch)
2009-10-06 13:03 PDT, Dave Hyatt 		aroben: review+
DetailsFormatted DiffDiff
Patch (16.54 KB, patch)
2009-10-06 14:23 PDT, Dave Hyatt 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2009-10-06 12:50:37 PDT
Created attachment 40737 [details] Add support for beforeload for stylesheet loads
Dave Hyatt
Comment 2 2009-10-06 13:03:08 PDT
Created attachment 40738 [details] Patch
Adam Roben (:aroben)
Comment 3 2009-10-06 13:12:03 PDT
Comment on attachment 40738 [details] Patch It would be good to add comments/tests for the bug fixes you made to ProcessingInstruction and HTMLLinkElement. It would also be good to add a test that uses ProcessingInstruction! r=me
Dave Hyatt
Comment 4 2009-10-06 14:23:42 PDT
Created attachment 40743 [details] Patch
Adam Roben (:aroben)
Comment 5 2009-10-06 14:59:44 PDT
Comment on attachment 40743 [details] Patch > void ProcessingInstruction::setData(const String& data, ExceptionCode&) > { > - int oldLength = m_data.length(); > m_data = data; > - document()->textRemoved(this, 0, oldLength); > + checkStyleSheet(); > } Why don't we need to call textRemoved anymore? Was it buggy? Is there anything we need to do for PIs that are not stylesheets? You should address at least some of these questions in your ChangeLog. You should add your new test to your ChangeLogs. r=me
Dave Hyatt
Comment 6 2009-10-06 15:28:07 PDT
Fixed in r49208.
Note You need to log in before you can comment on or make changes to this bug.