Bug 301255 – [WebXR Hit Test] XRRay

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Fujii Hironori]

[WebXR Hit Test] XRRay

This is a sub-task of bug#300754.

https://immersive-web.github.io/hit-test/#xrray-interface
https://www.w3.org/TR/webxr-hit-test-1/#xrray-interface

[Fujii Hironori]

Pull request: https://github.com/WebKit/WebKit/pull/52798

[EWS]

Committed 301987@main (b9d52d2f714f): <https://commits.webkit.org/301987@main>

Reviewed commits have been landed. Closing PR #52798 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/163229251>

[Fujii Hironori]

clang reports warnings.

In file included from /home/fujii/webkit/wb/WebKitBuild/GTK/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-15561f92-69.cpp:1:
/home/fujii/webkit/wb/Source/WebCore/Modules/webxr/WebXRRay.cpp:74:12: error: returning reference to local temporary object [-Werror,-Wreturn-stack-address]
   74 |     return DOMPointReadOnly::fromFloatPoint(m_origin);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/fujii/webkit/wb/Source/WebCore/Modules/webxr/WebXRRay.cpp:79:12: error: returning reference to local temporary object [-Werror,-Wreturn-stack-address]
   79 |     return DOMPointReadOnly::create(m_direction.x(), m_direction.y(), m_direction.z(), 0);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.

[Fujii Hironori]

Re-opening for pull request https://github.com/WebKit/WebKit/pull/52866

[EWS]

Committed 302016@main (7ef08aba259e): <https://commits.webkit.org/302016@main>

Reviewed commits have been landed. Closing PR #52866 and removing active labels.

[Fujii Hironori]

Re-opening for pull request https://github.com/WebKit/WebKit/pull/52880

[EWS]

Committed 302060@main (86abaa3fd071): <https://commits.webkit.org/302060@main>

Reviewed commits have been landed. Closing PR #52880 and removing active labels.