Bug 30100 - 1-char fix for obviously reverse condition.
Summary: 1-char fix for obviously reverse condition.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-05 15:49 PDT by Dmitry Titov
Modified: 2009-10-05 17:07 PDT (History)
0 users

See Also:

Attachments
Proposed fix. (1.01 KB, patch)
2009-10-05 15:54 PDT, Dmitry Titov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2009-10-05 15:49:58 PDT 
the patch is forthcoming.
Comment 1 Dmitry Titov 2009-10-05 15:54:09 PDT 
Created attachment 40669 [details]
Proposed fix.
Comment 2 Darin Adler 2009-10-05 15:56:42 PDT 
Comment on attachment 40669 [details]
Proposed fix.

It would be even better if we had some test that was failing because of this backward code. This was harmless. Why?

r=me
Comment 3 Dmitry Titov 2009-10-05 16:03:41 PDT 
the only place it was called from was destructor of ScriptCachedFramedata - so the RetainedPtr was destructed anyways and a window was released. The only difference was that gcController().garbageCollectSoon(); was not invoked, as WebKit usually tries to do after releasing a DOMWindow.
Comment 4 Dmitry Titov 2009-10-05 16:36:58 PDT 
sorry, should be 'after releasing JSDOMWindow'.
Comment 5 Dmitry Titov 2009-10-05 17:07:17 PDT 
landed: http://trac.webkit.org/changeset/49134