RESOLVED FIXED 30087
Web Inspector: Do not call nodeTitleInfo twice + followup fixes for r49101. 
https://bugs.webkit.org/show_bug.cgi?id=30087
Summary Web Inspector: Do not call nodeTitleInfo twice + followup fixes for r49101.
Pavel Feldman
Reported 2009-10-05 12:36:15 PDT
First call into nodeTitleInfo is only used for getting proper hasChildren value.
Attachments
patch (3.38 KB, patch)
2009-10-05 12:41 PDT, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-10-05 12:41:16 PDT
Created attachment 40651 [details] patch
Brian Weinstein
Comment 2 2009-10-05 12:58:36 PDT
Looks good here, but I'm not a reviewer. Sorry about missing those two changes from this -> node. :-(. - Empty () in the ChangeLog looks a little weird.
Timothy Hatcher
Comment 3 2009-10-05 14:43:57 PDT
Comment on attachment 40651 [details] patch > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > + (): We should figure out why htis happens and fix it.
Pavel Feldman
Comment 4 2009-10-06 05:03:45 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ElementsTreeOutline.js Committed r49173
Note You need to log in before you can comment on or make changes to this bug.