Bug 30077 - Add an ASSERT in updateGuidVersionMap.
Summary: Add an ASSERT in updateGuidVersionMap.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ben Murdoch
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-05 09:15 PDT by Ben Murdoch
Modified: 2009-10-05 10:30 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (1.26 KB, patch)
2009-10-05 10:14 PDT, Ben Murdoch 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Murdoch 2009-10-05 09:15:43 PDT 
The fix for https://bugs.webkit.org/show_bug.cgi?id=27836 should ASSERT that the guid map mutex is locked in updateGuidVersionMap.
Comment 1 Ben Murdoch 2009-10-05 10:14:56 PDT 
Created attachment 40639 [details]
Proposed patch
Comment 2 Darin Adler 2009-10-05 10:16:19 PDT 
Comment on attachment 40639 [details]
Proposed patch

>  // NOTE: Caller must lock guidMutex().
>  static inline void updateGuidVersionMap(int guid, String newVersion)
>  {
> +    // Ensure the the mutex is locked.
> +    ASSERT(!guidMutex().tryLock());

I wish there was some way to merge those two comments into one!

r=me
Comment 3 WebKit Commit Bot 2009-10-05 10:30:42 PDT 
Comment on attachment 40639 [details]
Proposed patch

Clearing flags on attachment: 40639

Committed r49099: <http://trac.webkit.org/changeset/49099>
Comment 4 WebKit Commit Bot 2009-10-05 10:30:45 PDT 
All reviewed patches have been landed.  Closing bug.