RESOLVED FIXED 30077
Add an ASSERT in updateGuidVersionMap. 
https://bugs.webkit.org/show_bug.cgi?id=30077
Summary Add an ASSERT in updateGuidVersionMap.
Ben Murdoch
Reported 2009-10-05 09:15:43 PDT
The fix for https://bugs.webkit.org/show_bug.cgi?id=27836 should ASSERT that the guid map mutex is locked in updateGuidVersionMap.
Attachments
Proposed patch (1.26 KB, patch)
2009-10-05 10:14 PDT, Ben Murdoch 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ben Murdoch
Comment 1 2009-10-05 10:14:56 PDT
Created attachment 40639 [details] Proposed patch
Darin Adler
Comment 2 2009-10-05 10:16:19 PDT
Comment on attachment 40639 [details] Proposed patch > // NOTE: Caller must lock guidMutex(). > static inline void updateGuidVersionMap(int guid, String newVersion) > { > + // Ensure the the mutex is locked. > + ASSERT(!guidMutex().tryLock()); I wish there was some way to merge those two comments into one! r=me
WebKit Commit Bot
Comment 3 2009-10-05 10:30:42 PDT
Comment on attachment 40639 [details] Proposed patch Clearing flags on attachment: 40639 Committed r49099: <http://trac.webkit.org/changeset/49099>
WebKit Commit Bot
Comment 4 2009-10-05 10:30:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.