Bug 300714 – [Win] Access is denied when removing files in WebKitBuild

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ian Grunert]

Sometimes there's files left in WebKitBuild that PowerShell and msys python is unable to remove, but the rm utility in bash is able to.

Make extractBuiltProduct use rm first to hopefully avoid this error.

```
python3 Tools/CISupport/built-product-archive --platform=win --release extract
 in dir C:\BW\Win-Tests-EWS\build (timeout 1200 secs)
 watching logfiles {}
 argv: [b'python3', b'Tools/CISupport/built-product-archive', b'--platform=win', b'--release', b'extract']
 using PTY: False
Traceback (most recent call last):
  File "C:\BW\Win-Tests-EWS\build\Tools\CISupport\built-product-archive", line 361, in <module>
    sys.exit(main())
             ^^^^^^
  File "C:\BW\Win-Tests-EWS\build\Tools\CISupport\built-product-archive", line 84, in main
    return extractBuiltProduct(options.configuration, genericPlatform)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\BW\Win-Tests-EWS\build\Tools\CISupport\built-product-archive", line 349, in extractBuiltProduct
    removeDirectoryIfExists(_configurationBuildDirectory)
  File "C:\BW\Win-Tests-EWS\build\Tools\CISupport\built-product-archive", line 118, in removeDirectoryIfExists
    shutil.rmtree(thinDirectory)
  File "C:\tools\python3\Lib\shutil.py", line 781, in rmtree
    return _rmtree_unsafe(path, onexc)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\tools\python3\Lib\shutil.py", line 635, in _rmtree_unsafe
    onexc(os.unlink, fullname, err)
  File "C:\tools\python3\Lib\shutil.py", line 633, in _rmtree_unsafe
    os.unlink(fullname)
PermissionError: [WinError 5] Access is denied: 'C:\\BW\\Win-Tests-EWS\\build\\WebKitBuild\\Release\\bin\\libGLESv2.dll'
program finished with exit code 1
elapsedTime=0.890777
```

[Ian Grunert]

Pull request: https://github.com/WebKit/WebKit/pull/52310

[EWS]

Committed 301835@main (9516ecd60932): <https://commits.webkit.org/301835@main>

Reviewed commits have been landed. Closing PR #52310 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/163073139>