Bug 30069 - [Qt] Remove precompiled header from JavaScriptCore compilation to allow autonomous compilation.
Summary: [Qt] Remove precompiled header from JavaScriptCore compilation to allow auton...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-10-05 03:51 PDT by Jocelyn Turcotte
Modified: 2009-10-05 16:19 PDT (History)
1 user (show)

See Also:

Attachments
Patch (970 bytes, patch)
2009-10-05 03:52 PDT, Jocelyn Turcotte 		no flags Details | Formatted Diff | Diff
Patch v0.2 (993 bytes, patch)
2009-10-05 03:57 PDT, Jocelyn Turcotte 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2009-10-05 03:51:06 PDT 
JavaScriptCore.pro includes its pch from WebKit/qt/WebKit_pch.h, which displays a warning when compiling an extracted standalone JavaScriptCore.

This is the simple solution, needed at least while we need JavaScriptCore to be compiled out of WebKit inside Qt.
It would be possible to create a pch especially for JavaScriptCore to keep the compilation time reduction, however this may polute the directory (or any of the reason why WebKit_pch.h is currently in WebKit/qt/)

Please have a thought about it while reviewing.
Comment 1 Jocelyn Turcotte 2009-10-05 03:52:56 PDT 
Created attachment 40618 [details]
Patch
Comment 2 Jocelyn Turcotte 2009-10-05 03:57:00 PDT 
Created attachment 40620 [details]
Patch v0.2

Better changelog message
Comment 3 Simon Hausmann 2009-10-05 14:57:04 PDT 
Comment on attachment 40620 [details]
Patch v0.2

r=me, that header isn't needed anymore for this .pro file.
Comment 4 WebKit Commit Bot 2009-10-05 16:19:04 PDT 
Comment on attachment 40620 [details]
Patch v0.2

Clearing flags on attachment: 40620

Committed r49128: <http://trac.webkit.org/changeset/49128>
Comment 5 WebKit Commit Bot 2009-10-05 16:19:07 PDT 
All reviewed patches have been landed.  Closing bug.