30064 – Syntax Highlighting CSS shouldn't be duplicated

Bug 30064 - Syntax Highlighting CSS shouldn't be duplicated

Summary: Syntax Highlighting CSS shouldn't be duplicated

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (Deprecated) (show other bugs)
Version:	528+ (Nightly build)
Hardware:	PC OS X 10.5

Importance:	P2 Normal
Assignee:	Brian Weinstein

URL:
Keywords:

Depends on:
Blocks:

Reported:	2009-10-04 21:38 PDT by Brian Weinstein
Modified:	2009-10-04 22:37 PDT (History)
CC List:	2 users (show)

See Also:

Attachments
CSS Refactor (8.74 KB, patch) 2009-10-04 21:49 PDT, Brian Weinstein	bweinstein: commit-queue-	Details \| Formatted Diff \| Diff
Fix extra typo + Add bug link (9.43 KB, patch) 2009-10-04 22:01 PDT, Brian Weinstein	timothy: review- bweinstein: commit-queue-	Details \| Formatted Diff \| Diff
Also WebKit.qrc (9.99 KB, patch) 2009-10-04 22:22 PDT, Brian Weinstein	timothy: review+ bweinstein: commit-queue-	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Brian Weinstein 2009-10-04 21:38:56 PDT

There should be a common CSS file that handles the styling of syntax highlighting.

Comment 1 Brian Weinstein 2009-10-04 21:49:15 PDT

Created attachment 40609 [details]
CSS Refactor

Comment 2 Joseph Pecoraro 2009-10-04 21:56:29 PDT

Excellent =). A few tiny things:

1. When this gets reviewed can you fix a typo in SourceFrame.js?  In the comments above all that styleText there is a typo "(becuase it is a user agent sheet.)".  "because" is spelled wrong. Could fix that?

2. Forgot a link to this bug in the ChangeLog?  prepare-Changelog --bug #### will auto fill that part in for you.

Comment 3 Brian Weinstein 2009-10-04 21:58:57 PDT

(In reply to comment #2)
> Excellent =). A few tiny things:
> 
> 1. When this gets reviewed can you fix a typo in SourceFrame.js?  In the
> comments above all that styleText there is a typo "(becuase it is a user agent
> sheet.)".  "because" is spelled wrong. Could fix that?
> 

I can take care of that as part of this patch. It looks like highlight is misspelled about 10 times elsewhere in that file, so I'll put that in a different patch.

> 2. Forgot a link to this bug in the ChangeLog?  prepare-Changelog --bug ####
> will auto fill that part in for you.

Yeah, I forgot to link to the bug. Will do.

Comment 4 Brian Weinstein 2009-10-04 22:01:30 PDT

Created attachment 40610 [details]
Fix extra typo + Add bug link

Comment 5 Timothy Hatcher 2009-10-04 22:12:45 PDT

Comment on attachment 40610 [details]
Fix extra typo + Add bug link

Needs added to WebKit.qrc for Qt.

Comment 6 Brian Weinstein 2009-10-04 22:22:19 PDT

Created attachment 40611 [details]
Also WebKit.qrc

Comment 7 Brian Weinstein 2009-10-04 22:37:41 PDT

Commited in http://trac.webkit.org/changeset/49082.