Bug 30061 - [Gtk][Layout tests] Generate results for editing tests
Summary: [Gtk][Layout tests] Generate results for editing tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-10-04 11:20 PDT by Zan Dobersek
Modified: 2009-10-06 10:24 PDT (History)
1 user (show)

See Also:

Generated results (deleted)
2009-10-04 11:37 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2009-10-04 11:20:35 PDT
Currently, about 730 tests in editing/ directory need to have results generated.
Comment 1 Zan Dobersek 2009-10-04 11:37:02 PDT
Created attachment 40598 [details]
Generated results

This patch adds generated test results for about 350 tests. Only these tests produce 'rendering-equal' results to those from the mac port.

With 'rendering-equal' phrase, these guarantees are meant:
- Equal render objects are created in the same places (not necessarrily in the exact same position and with exact same size)
- These objects have equal CSS attributes (borders, color etc.)
- In the case of text runs, they contain equal text
- Equal caret and selection attributes dump
Basically, they're semantically equal, there can be differences in the size and position of render objects because of different font metrics.

Tests that do not produce 'rendering-equal' results should be listed in another bug, examined and then fixed if fixable or added as generated if they're not fixable and acceptable as such.
Comment 2 Eric Seidel (no email) 2009-10-05 09:27:43 PDT
Comment on attachment 40598 [details]
Generated results

It is very sad that so many of these are render tree dumps instead of being dumpAsText (but that's not your fault).

Comment 3 Gustavo Noronha (kov) 2009-10-06 10:08:13 PDT
Comment on attachment 40598 [details]
Generated results

Setting cq+, since Zan is not a committer.
Comment 4 WebKit Commit Bot 2009-10-06 10:24:41 PDT
Comment on attachment 40598 [details]
Generated results

Clearing flags on attachment: 40598

Committed r49192: <http://trac.webkit.org/changeset/49192>
Comment 5 WebKit Commit Bot 2009-10-06 10:24:45 PDT
All reviewed patches have been landed.  Closing bug.