Bug 30057 - Web Inspector: Adding new attributes in Element Panel is counterintuitive
Summary: Web Inspector: Adding new attributes in Element Panel is counterintuitive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-04 03:34 PDT by Pavel Feldman
Modified: 2012-07-26 21:47 PDT (History)
5 users (show)

See Also:


Attachments
[IMAGE] Screenshot (205.40 KB, image/png)
2009-10-04 03:36 PDT, Pavel Feldman
no flags Details
[PATCH] Suggested fix (4.00 KB, patch)
2009-10-04 03:41 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-10-04 03:34:33 PDT
Follow up to https://bugs.webkit.org/show_bug.cgi?id=21108:

> - I kept it a "..." but now everything else is out of the way so it will be easy to experiment with this.

It really looks confusing as is and I think we should revisit this. When I first saw "..." on hover, I thought it was a bug: I was sure that hovered text became longer, went out of bounds and CSS truncated it and added ellipsis to it.

Two thing bother me most:
1) Discoverability: There is no way user would understand that ellipsis is for adding new attributes
2) Stuff jumping: Elements panel contents is jumping when I move mouse around. Sometime I miss text nodes that I want to edit.

I'd suggest that we 
1) replace "..." with " ?="
2) toggle add attribute span using setTimeout(500).

Attaching screenshot and a patch shortly.
Comment 1 Pavel Feldman 2009-10-04 03:36:45 PDT
Created attachment 40593 [details]
[IMAGE] Screenshot
Comment 2 Pavel Feldman 2009-10-04 03:41:47 PDT
Created attachment 40594 [details]
[PATCH] Suggested fix
Comment 3 Timothy Hatcher 2009-10-09 13:14:19 PDT
Comment on attachment 40594 [details]
[PATCH] Suggested fix

I'm not too fond of the look. But it does make it clear. I do like the hysteresis.

Maybe an icon would be better in the long run?
Comment 4 Pavel Feldman 2009-10-10 12:21:46 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
Committed r49419
Comment 5 Jiayong Ou 2009-11-10 05:11:01 PST
> Maybe an icon would be better in the long run?

An Icon would be much better. 

I just wanted to file a bug report on it since it looks like garbaged data…