RESOLVED FIXED30053
[Qt] dragging an image that is a link does not set the title or the link url 
https://bugs.webkit.org/show_bug.cgi?id=30053
Summary [Qt] dragging an image that is a link does not set the title or the link url
Benjamin Meyer
Reported 2009-10-03 22:51:30 PDT
Created attachment 40590 [details] patch Match the behavior of other WebKit browser and have the first url of the drag data be the url passed in declareAndWriteDragImage and set the text of the drag data to be the title argument.
Attachments
patch (1.61 KB, patch)
2009-10-03 22:51 PDT, Benjamin Meyer 		eric: review-
DetailsFormatted DiffDiff
patch (2.39 KB, patch)
2009-10-05 22:27 PDT, Benjamin Meyer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-10-05 09:24:42 PDT
Comment on attachment 40590 [details] patch In general this looks great. For changes like this generally we ask for manual tests to be added to WebCore/manual-tests, although I suspect one is already there for this sort of behavior. Every change requires a ChangeLog. r-
Benjamin Meyer
Comment 2 2009-10-05 09:28:18 PDT
It would be nice when there is a git commit it showed up in the review and the commit tool could run prepare-changelog so we didn't have to do it manually.
Benjamin Meyer
Comment 3 2009-10-05 22:27:14 PDT
Created attachment 40690 [details] patch
WebKit Commit Bot
Comment 4 2009-10-06 12:02:51 PDT
Comment on attachment 40690 [details] patch Clearing flags on attachment: 40690 Committed r49201: <http://trac.webkit.org/changeset/49201>
WebKit Commit Bot
Comment 5 2009-10-06 12:02:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.