Bug 30047 – Incomplete repaint of text field in relative positioned inline at imdb.com

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

When typing in the search field at the top of <http://www.imdb.com/>, the bottom part of the text and of the insertion point is not painted at all times. Forcing a repaint corrects it.

REGRESSION:
The bug exists in TOT (r49059) as well as in Safari 4.0.3.

<rdar://problem/7273751>

Created attachment 40578 [details]
Reduction

Maybe this is a duplicate of bug 28700.

Created attachment 41989 [details]
Implement offsetFromContainer(), mapLocalToContainer() and mapAbsoluteToLocalPoint() in RenderInline

[Simon Fraser (smfr)]

Comment on attachment 41989 [details]
Implement offsetFromContainer(), mapLocalToContainer() and mapAbsoluteToLocalPoint() in RenderInline

> +void RenderInline::mapLocalToContainer(RenderBoxModelObject* repaintContainer, bool useTransforms, bool fixed, TransformState& transformState) const

> +    bool preserve3D = useTransforms && (o->style()->preserves3D() || style()->preserves3D());
> +    if (useTransforms && shouldUseTransformFromContainer(o)) {

I don't think you'll ever fall into this path.shouldUseTransformFromContainer() checks to see if the layer has a transform, and that will never happen for inlines.

> +    if (useTransforms && shouldUseTransformFromContainer(o)) {

Ditto

r=me with those changes if you agree.

Fixed in <http://trac.webkit.org/changeset/50184>.

(In reply to comment #3)
> Maybe this is a duplicate of bug 28700.

Unfortunately, it’s not.

[Kenneth Rohde Christiansen]

You checked in cross platform test result, but our Qt result differs slightly.

-layer at (8,88) size 100x18
-  RenderInline (relative positioned) {SPAN} at (0,0) size 100x18
+layer at (8,88) size 100x21
+  RenderInline (relative positioned) {SPAN} at (0,0) size 100x21

which I guess it due to using a different font.

Should I just checkin a platform dependent result for Qt?