Bug 30044 - [Qt] EventSender::keyDown() cannot send function-key events.
Summary: [Qt] EventSender::keyDown() cannot send function-key events.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-10-03 07:26 PDT by Jakub Wieczorek
Modified: 2009-10-05 15:37 PDT (History)
1 user (show)

See Also:

Attachments
patch (1.98 KB, patch)
2009-10-03 07:28 PDT, Jakub Wieczorek 		eric: review+
Details | Formatted Diff | Diff
patch (2.31 KB, patch)
2009-10-05 09:59 PDT, Jakub Wieczorek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Wieczorek 2009-10-03 07:26:11 PDT 
This is required for the fast/events/keydown-function-keys.html layout test.
Comment 1 Jakub Wieczorek 2009-10-03 07:28:51 PDT 
Created attachment 40573 [details]
patch
Comment 2 Eric Seidel (no email) 2009-10-05 09:20:31 PDT 
Comment on attachment 40573 [details]
patch

Looks OK, but the ChangeLog should say what layout test this fixes.
Comment 3 Jakub Wieczorek 2009-10-05 09:59:26 PDT 
Created attachment 40638 [details]
patch

(In reply to comment #2)
> (From update of attachment 40573 [details])
> Looks OK, but the ChangeLog should say what layout test this fixes.

The patch itself does not fix the above mentioned test failure because there's one more bug in Qt DRT that makes the test fail: https://bugs.webkit.org/show_bug.cgi?id=30043

I've also added ' && functionKey <= 35' to the assertion, just in case.
Comment 4 Simon Hausmann 2009-10-05 14:47:20 PDT 
Comment on attachment 40638 [details]
patch

r=me, but please also make a patch that removes the skipped test from the list. Or in the future you could do that in one single change :-)
Comment 5 WebKit Commit Bot 2009-10-05 15:37:41 PDT 
Comment on attachment 40638 [details]
patch

Clearing flags on attachment: 40638

Committed r49118: <http://trac.webkit.org/changeset/49118>
Comment 6 WebKit Commit Bot 2009-10-05 15:37:44 PDT 
All reviewed patches have been landed.  Closing bug.