RESOLVED FIXED300324
webkit_web_extension_match_pattern_register_custom_URL_scheme should not be uppercased 
https://bugs.webkit.org/show_bug.cgi?id=300324
Summary webkit_web_extension_match_pattern_register_custom_URL_scheme should not be u...
Jamie Murphy
Reported 2025-10-07 07:47:51 PDT
This function should instead be webkit_web_extension_match_pattern_register_custom_url_scheme
Attachments
Add attachment proposed patch, testcase, etc.
Jamie Murphy
Comment 1 2025-10-07 07:49:18 PDT
Pull request: https://github.com/WebKit/WebKit/pull/51943
EWS
Comment 2 2025-10-08 14:42:37 PDT
Committed 301230@main (f2ee8ad67867): <https://commits.webkit.org/301230@main> Reviewed commits have been landed. Closing PR #51943 and removing active labels.
Diego Pino
Comment 3 2025-10-08 19:30:04 PDT
It seems compilation with GTK3 started failing after this patch: https://build.webkit.org/#/builders/1519 The build error is: ``` In file included from /home/buildbot-worker/GTK-Linux-64-bit-Release-GTK3-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:29:/home/buildbot-worker/GTK-Linux-64-bit-Release-GTK3-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit2/webkit2.h:92:10: fatal error: webkit/WebKitWebExtensionMatchPattern.h: No such file or directory 92 | #include <webkit/WebKitWebExtensionMatchPattern.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~compilation terminated. ```
Jamie Murphy
Comment 4 2025-10-08 21:24:35 PDT
Hm, no, not this patch. Changeset 301195@main moved the header file to only be included if GTK4 is enabled, but changeset 301229@main does the exact opposite in the main include for webkit2.h.
Note You need to log in before you can comment on or make changes to this bug.