RESOLVED FIXED300158
Update SQLiteDatabase::prepareStatement() to return a std::unique_ptr instead of an std::expected 
https://bugs.webkit.org/show_bug.cgi?id=300158
Summary Update SQLiteDatabase::prepareStatement() to return a std::unique_ptr instead...
Chris Dumez
Reported 2025-10-03 19:14:38 PDT
Update SQLiteDatabase::prepareStatement() to return a std::unique_ptr instead of an std::expected. Returning a std::expected containing a SQLiteStatement doesn't play nice with Safer CPP static analysis and reports false positives. Using a `std::unique_ptr<SQLiteStatement>` makes static analysis happy without having to make the code more verbose.
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2025-10-03 19:22:14 PDT
Pull request: https://github.com/WebKit/WebKit/pull/51798
EWS
Comment 2 2025-10-05 03:11:14 PDT
Committed 301020@main (a6e7d5013931): <https://commits.webkit.org/301020@main> Reviewed commits have been landed. Closing PR #51798 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2025-10-05 03:13:03 PDT
<rdar://problem/161983876>
Radar WebKit Bug Importer
Comment 4 2025-10-05 03:13:04 PDT
<rdar://problem/161984037>
Note You need to log in before you can comment on or make changes to this bug.