Bug 30006 - [GStreamer] Unnecessary checks for Messages types in callbacks
Summary: [GStreamer] Unnecessary checks for Messages types in callbacks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-02 01:54 PDT by Sebastian Dröge (slomo)
Modified: 2009-10-15 06:10 PDT (History)
2 users (show)

See Also:

Attachments
proposed patch (7.13 KB, patch)
2009-10-14 06:16 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Dröge (slomo) 2009-10-02 01:54:32 PDT 
The EOS/StateChange/Error callbacks check the message type but they can only be called with that exact message. The check should be removed ;)

Also instead of 3-4 different callbacks for all messages types it might make sense to only use a single one, with a switch over the message types.
Comment 1 Philippe Normand 2009-10-14 06:16:34 PDT 
Created attachment 41158 [details]
proposed patch
Comment 2 Sebastian Dröge (slomo) 2009-10-14 06:47:07 PDT 
Looks good to me
Comment 3 WebKit Commit Bot 2009-10-15 06:10:09 PDT 
Comment on attachment 41158 [details]
proposed patch

Clearing flags on attachment: 41158

Committed r49621: <http://trac.webkit.org/changeset/49621>
Comment 4 WebKit Commit Bot 2009-10-15 06:10:12 PDT 
All reviewed patches have been landed.  Closing bug.