Bug 30003 - [GStreamer] READY state doesn't mean "enough data"
Summary: [GStreamer] READY state doesn't mean "enough data"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-02 01:45 PDT by Sebastian Dröge (slomo)
Modified: 2009-10-15 07:47 PDT (History)
2 users (show)

See Also:

Attachments
proposed patch (2.55 KB, patch)
2009-10-15 02:23 PDT, Philippe Normand 		gustavo: review-
Details | Formatted Diff | Diff
now with bug link (2.61 KB, patch)
2009-10-15 06:05 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Dröge (slomo) 2009-10-02 01:45:16 PDT 
Hi,
currently in MediaPlayerPrivate::updateStates() it is assumed that READY means that there is enough data. That's not true, READY only means that devices could be opened successfully, not that the sinks already has the first data. That's only true for PAUSED or PLAYING.
Comment 1 Philippe Normand 2009-10-15 02:23:45 PDT 
Created attachment 41214 [details]
proposed patch
Comment 2 Gustavo Noronha (kov) 2009-10-15 06:00:18 PDT 
Comment on attachment 41214 [details]
proposed patch

Can you add the bug URL to the ChangeLog? =)
Comment 3 Philippe Normand 2009-10-15 06:05:59 PDT 
Created attachment 41222 [details]
now with bug link
Comment 4 WebKit Commit Bot 2009-10-15 07:46:56 PDT 
Comment on attachment 41222 [details]
now with bug link

Clearing flags on attachment: 41222

Committed r49626: <http://trac.webkit.org/changeset/49626>
Comment 5 WebKit Commit Bot 2009-10-15 07:47:00 PDT 
All reviewed patches have been landed.  Closing bug.