Bug 29998 – [GStreamer] Should probably scale video frames to requested size

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Sebastian Dröge (slomo)]

Hi,
currently the MediaPlayer only scales the video frames to the p-a-r but keeps everything else as is. I think it should additionally scale the frames to fit the requested size as good as possible (while keeping the p-a-r). With requested size I mean what gets passed to MediaPlayerPrivate::setSize().

Important here is, that you really really should make sure that a) the par is kept and b) both width and height are <= the requested size

[Sebastian Dröge (slomo)]

Created attachment 41023 [details]
scale-video.diff

Patch on top of the one from bug #29997.

[Gustavo Noronha (kov)]

Comment on attachment 41023 [details]
scale-video.diff

Nice =). So, what I said in #29997 regarding coding style mostly applies to this one too. Since this one is basically a follow-up to that one, I'll say r- for now.

[Sebastian Dröge (slomo)]

Created attachment 41038 [details]
scale-video.diff

[Gustavo Noronha (kov)]

Comment on attachment 41038 [details]
scale-video.diff

Thanks!

[WebKit Commit Bot]

Comment on attachment 41038 [details]
scale-video.diff

Clearing flags on attachment: 41038

Committed r49439: <http://trac.webkit.org/changeset/49439>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.