Bug 299885 – [CSS Zoom] Take 2: Apply zoom factor to border-spacing and border width (after revert)

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Taher]

After 300756@main reverted. We need to re-land this by addressing unresolved feedback.

[Radar WebKit Bug Importer]

<rdar://problem/161669263>

[Taher]

Pull request: https://github.com/WebKit/WebKit/pull/51583

[EWS]

Committed 301536@main (c38095edbbdb): <https://commits.webkit.org/301536@main>

Reviewed commits have been landed. Closing PR #51583 and removing active labels.

[Diego Pino]

This changeset broke the WPE build for ARM 32-bit:

https://build.webkit.org/#/builders/860/builds/24486

The build error is:

/home/buildbot/worker/WPE-Linux-ARM32-bit-Release-Debian-Stable-Build/build/Source/WebCore/rendering/style/StyleRareInheritedData.cpp:74:15: error: static assertion failed due to requirement 'sizeof(WebCore::StyleRareInheritedData) <= sizeof(WebCore::GreaterThanOrSameSizeAsStyleRareInheritedData)': StyleRareInheritedData should bit pack
   74 | static_assert(sizeof(StyleRareInheritedData) <= sizeof(GreaterThanOrSameSizeAsStyleRareInheritedData), "StyleRareInheritedData should bit pack");
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/buildbot/worker/WPE-Linux-ARM32-bit-Release-Debian-Stable-Build/build/Source/WebCore/rendering/style/StyleRareInheritedData.cpp:74:46: note: expression evaluates to '416 <= 408'
   74 | static_assert(sizeof(StyleRareInheritedData) <= sizeof(GreaterThanOrSameSizeAsStyleRareInheritedData), "StyleRareInheritedData should bit pack");

The issue is that the patch added a new field, deviceScaleFactor, to class StyleRareInheritedData without adding a field of the same size to class GreaterThanOrSameSizeAsStyleRareInheritedData.

I don't understand why the build error was caught only by the 32-bit build and not the 64-bit though.

[Diego Pino]

Re-opening for pull request https://github.com/WebKit/WebKit/pull/52453

[EWS]

Committed 301686@main (6da2789184a8): <https://commits.webkit.org/301686@main>

Reviewed commits have been landed. Closing PR #52453 and removing active labels.

[Sammy Gill]

WPT export: https://github.com/web-platform-tests/wpt/pull/55727

[Tim Nguyen (:ntim)]

rdar://161008191