Bug 29981 - REGRESSION (r45945): After pressing Shift-PageDown, pressing Shift-Up extends the top of the selection upwards (but should shrink the selection instead)
Summary: REGRESSION (r45945): After pressing Shift-PageDown, pressing Shift-Up extends...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Enrica Casucci
URL: data:text/html,%3Ctextarea%20rows=40%...
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2009-10-01 14:08 PDT by Adam Roben (:aroben)
Modified: 2009-10-27 11:54 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.22 KB, patch)
2009-10-23 11:08 PDT, Enrica Casucci 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-10-01 14:08:40 PDT 
To reproduce:

1. Go to data:text/html,%3Ctextarea%20rows=40%3Etest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%0Atest%3C/textarea%3E
2. Click at least one line below the top of the textarea
3. Press Shift-PageDown
4. Press Shift-Up

The top of the selection extends upwards. But the bottom of the extension should shrink upwards, instead.

This happens on both Mac and Windows. It did not happen in Safari 4.0.3.
Comment 1 Adam Roben (:aroben) 2009-10-01 14:09:13 PDT 
<rdar://problem/7269075>
Comment 2 Enrica Casucci 2009-10-23 11:08:19 PDT 
Created attachment 41733 [details]
Patch
Comment 3 Adele Peterson 2009-10-23 12:02:23 PDT 
Comment on attachment 41733 [details]
Patch

I think it should be possible to add a layout test for this.
Comment 4 Adele Peterson 2009-10-23 17:14:47 PDT 
Comment on attachment 41733 [details]
Patch

Clearing the review patch, since Enrica is going to upload a new version w/ a test
Comment 5 Darin Adler 2009-10-25 13:04:05 PDT 
My bad. Fix looks good.
Comment 6 Adele Peterson 2009-10-27 11:54:24 PDT 
I added a test case, and checked in revision 50165.