Bug 29971 - Clean up warnings in WebCore/bindings/v8/npruntime.cpp
Summary: Clean up warnings in WebCore/bindings/v8/npruntime.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P5 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-01 10:23 PDT by Dave MacLachlan
Modified: 2009-10-02 00:42 PDT (History)
1 user (show)

See Also:

Attachments
Path to get rid of warnings. (1.74 KB, patch)
2009-10-01 10:23 PDT, Dave MacLachlan 		levin: review-
Details | Formatted Diff | Diff
Patch with revisions (1.87 KB, patch)
2009-10-01 21:27 PDT, Dave MacLachlan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave MacLachlan 2009-10-01 10:23:00 PDT 
Created attachment 40457 [details]
Path to get rid of warnings.

Gets rid of warnings on gcc about using anonymous namespaces 
warning: 'StringKeyHashTraits' has a base  'WTF::GenericHashTraits<<unnamed>::StringKey>' whose type uses the anonymous namespace
warning: 'WTF::PairHashTraits<StringKeyHashTraits, WTF::HashTraits<PrivateIdentifier*> >' has a base 'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey, PrivateIdentifier*> >' whose type uses the anonymous namespace
Comment 1 David Levin 2009-10-01 21:16:31 PDT 
Comment on attachment 40457 [details]
Path to get rid of warnings.

minor change log fixes suggested.

> Index: WebCore/ChangeLog
> +2009-10-01  Dave MacLachlan  <dmaclach@gmail.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
Add:
bug title
bug link
blank line
then your description.

> +        Gets rid of warnings on gcc about using anonymous namespaces 
> +          warning: 'StringKeyHashTraits' has a base
> +         'WTF::GenericHashTraits<<unnamed>::StringKey>' 
> +          whose type uses the anonymous namespace
> +	and

The spacing on this looks off. I think every in descriptions is indented beyond this in the changelog.

> +          warning: 'WTF::PairHashTraits<StringKeyHashTraits,
> +          WTF::HashTraits<PrivateIdentifier*> >' has a base
> +         'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey,
> +         PrivateIdentifier*> >' whose type uses the anonymous namespace
> +
> +        No tests required.
> +
> +        * bindings/v8/npruntime.cpp:
> +
Comment 2 Dave MacLachlan 2009-10-01 21:27:18 PDT 
Created attachment 40495 [details]
Patch with revisions
Comment 3 WebKit Commit Bot 2009-10-02 00:41:58 PDT 
Comment on attachment 40495 [details]
Patch with revisions

Clearing flags on attachment: 40495

Committed r49011: <http://trac.webkit.org/changeset/49011>
Comment 4 WebKit Commit Bot 2009-10-02 00:42:02 PDT 
All reviewed patches have been landed.  Closing bug.