Bug 29971 – Clean up warnings in WebCore/bindings/v8/npruntime.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Dave MacLachlan]

Created attachment 40457 [details]
Path to get rid of warnings.

Gets rid of warnings on gcc about using anonymous namespaces 
warning: 'StringKeyHashTraits' has a base  'WTF::GenericHashTraits<<unnamed>::StringKey>' whose type uses the anonymous namespace
warning: 'WTF::PairHashTraits<StringKeyHashTraits, WTF::HashTraits<PrivateIdentifier*> >' has a base 'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey, PrivateIdentifier*> >' whose type uses the anonymous namespace

[David Levin]

Comment on attachment 40457 [details]
Path to get rid of warnings.

minor change log fixes suggested.

> Index: WebCore/ChangeLog
> [phone]  Dave MacLachlan  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
Add:
bug title
bug link
blank line
then your description.

> +        Gets rid of warnings on gcc about using anonymous namespaces 
> +          warning: 'StringKeyHashTraits' has a base
> +         'WTF::GenericHashTraits<<unnamed>::StringKey>' 
> +          whose type uses the anonymous namespace
> +	and

The spacing on this looks off. I think every in descriptions is indented beyond this in the changelog.

> +          warning: 'WTF::PairHashTraits<StringKeyHashTraits,
> +          WTF::HashTraits<PrivateIdentifier*> >' has a base
> +         'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey,
> +         PrivateIdentifier*> >' whose type uses the anonymous namespace
> +
> +        No tests required.
> +
> +        * bindings/v8/npruntime.cpp:
> +

[Dave MacLachlan]

Created attachment 40495 [details]
Patch with revisions

[WebKit Commit Bot]

Comment on attachment 40495 [details]
Patch with revisions

Clearing flags on attachment: 40495

Committed r49011: <http://trac.webkit.org/changeset/49011>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.