Bug 29960 - [GTK] media player: better mute support
Summary: [GTK] media player: better mute support
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-10-01 06:27 PDT by Philippe Normand
Modified: 2009-10-01 10:17 PDT (History)
2 users (show)

See Also:

proposed patch (2.22 KB, patch)
2009-10-01 06:40 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2009-10-01 06:27:42 PDT
As pointed out by slomo :)

MediaPlayerPrivateGStreamer.cpp in setMuted() it should really use
the "mute" property of playbin2. That keeps the current volume and just
mutes the audio ;)
Comment 1 Philippe Normand 2009-10-01 06:40:33 PDT
Created attachment 40438 [details]
proposed patch
Comment 2 Gustavo Noronha (kov) 2009-10-01 08:59:58 PDT
Comment on attachment 40438 [details]
proposed patch

Very good.
Comment 3 WebKit Commit Bot 2009-10-01 10:17:21 PDT
Comment on attachment 40438 [details]
proposed patch

Clearing flags on attachment: 40438

Committed r48980: <http://trac.webkit.org/changeset/48980>
Comment 4 WebKit Commit Bot 2009-10-01 10:17:26 PDT
All reviewed patches have been landed.  Closing bug.