WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
299597
[CMake] Use imported targets in the GLib find-module
https://bugs.webkit.org/show_bug.cgi?id=299597
Summary
[CMake] Use imported targets in the GLib find-module
Adrian Perez
Reported
2025-09-26 04:25:47 PDT
It would be nicer to use imported targets in Source/cmake/FindGLIB.cmake
Attachments
Add attachment
proposed patch, testcase, etc.
Adrian Perez
Comment 1
2025-09-26 10:40:17 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/51395
EWS
Comment 2
2025-09-27 00:56:45 PDT
Committed
300628@main
(68a9c2d8e124): <
https://commits.webkit.org/300628@main
> Reviewed commits have been landed. Closing PR #51395 and removing active labels.
Diego Pino
Comment 3
2025-09-30 06:01:06 PDT
Patch broke Ubuntu 22.04 WPEWebKit build bot.
https://build.webkit.org/#/builders/1060/builds/13432
``` In file included from /home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-2204-Build/build/WebKitBuild/WPE/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-74.cpp:1: /home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-2204-Build/build/Source/WebCore/platform/mediastream/gstreamer/DesktopPortal.cpp:26:10: fatal error: gio/gunixfdlist.h: No such file or directory 26 | #include <gio/gunixfdlist.h> | ^~~~~~~~~~~~~~~~~~~ ```
Diego Pino
Comment 4
2025-09-30 06:01:37 PDT
Re-opening for pull request
https://github.com/WebKit/WebKit/pull/51563
EWS
Comment 5
2025-09-30 07:56:12 PDT
Committed
300750@main
(a4ac8823d8de): <
https://commits.webkit.org/300750@main
> Reviewed commits have been landed. Closing PR #51563 and removing active labels.
Adrian Perez
Comment 6
2025-10-09 14:48:04 PDT
There are still some uses of GLIB_INCLUDE_DIRS and GIO_[UNIX_]INCLUDE_DIRS, reopening to tackle those
Adrian Perez
Comment 7
2025-10-10 01:05:08 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/52107
EWS
Comment 8
2025-10-12 13:26:31 PDT
Committed
301384@main
(489ec3327c1a): <
https://commits.webkit.org/301384@main
> Reviewed commits have been landed. Closing PR #52107 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug