Bug 29943 – 307 redirects should pass along http body and Content-Type header

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Maciej Stachowiak]

307 redirects should pass along the http body and Content-Type header, in addition to the method. These are dropped by CFNetwork when converting the redirect to a GET.

[Maciej Stachowiak]

Created attachment 40413 [details]
patch v1

[Brady Eidson]

Comment on attachment 40413 [details]
patch v1

r=me with style issues to be fixed:

> Index: WebCore/platform/network/mac/ResourceHandleMac.mm
> ===================================================================
> --- WebCore/platform/network/mac/ResourceHandleMac.mm	(revision 48858)
> +++ WebCore/platform/network/mac/ResourceHandleMac.mm	(working copy)
> @@ -596,6 +596,15 @@ void ResourceHandle::receivedCancellatio
>          if (!equalIgnoringCase(originalMethod, String([newRequest HTTPMethod]))) {
>              NSMutableURLRequest *mutableRequest = [newRequest mutableCopy];
>              [mutableRequest setHTTPMethod:originalMethod];
> +	    
> +            FormData* body = m_handle->request().httpBody();
> +            if (!equalIgnoringCase(originalMethod, "GET") && body && !body->isEmpty())
> +                WebCore::setHTTPBody(mutableRequest, body);
> +
> +	    String originalContentType = m_handle->request().httpContentType();
> +	    if (!originalContentType.isEmpty())
> +	        [mutableRequest setValue:originalContentType forHTTPHeaderField:@"Content-Type"];
> +
>              newRequest = [mutableRequest autorelease];
>          }
>      }

There's tabs here (and therefore, maybe elsewhere in the change?) - please replace with spaces.  Maybe as a result, the indentation here is off.

[Maciej Stachowiak]

Committed, and I fixed the tabs.

[Maciej Stachowiak]

Committed r48953.
http://trac.webkit.org/changeset/48953

Also requires r48956 for Windows.
http://trac.webkit.org/changeset/48956

Also r48957.
http://trac.webkit.org/changeset/48957